dataset: pin validation shard #545
Closed
KartikVashishta wants to merge 4 commits intokarpathy:masterfrom
Closed
Conversation
svlandeg
reviewed
Feb 19, 2026
Collaborator
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the PR! I had a few comments, inline:
svlandeg
reviewed
Feb 19, 2026
KartikVashishta
force-pushed
the
fix/val-shard
branch
from
a63c3c3 to
0b8fde9
Compare
svlandeg
reviewed
Feb 20, 2026
svlandeg
reviewed
Feb 20, 2026
svlandeg
reviewed
Feb 20, 2026
svlandeg
approved these changes
Feb 20, 2026
Collaborator
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
I looked at the code diff and ran some quick tests with the branch of this PR and that all looks good, apart from a few nitpicking comments 😉
It makes sense to me to designate shard_01822.parquet as the standard validation one. The doc strings and UX messages have been updated accordingly.
Contributor
Author
|
Thanks for the review @svlandeg ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #541 Validation shard is fixed so val loss/bpb is stable regardless of how many shards were downloaded.